Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all examples for job windows_latest_cmake in CI #392

Merged
merged 8 commits into from
Jan 26, 2023

Conversation

FabienPean
Copy link
Contributor

@FabienPean FabienPean commented Jan 21, 2023

Binaries of examples were not able to find libarpack.dll and failing, while tests were passing. The main difference in CMakeLists was setting the working directory for examples and not for tests. The binaries are probably linked without an absolute path for the library and searching the DLL in local folder. Changing the working directory in CMake changed the search local path where the DLL is absent.

To fix using MPI examples on Windows, the following was necessary:

  • Add flag -fallow-invalid-boz fixing false positive errors on comments, e.g.
    • 87 | c 1. D.C. Sorensen, "Implicit Application of Polynomial Filters in
      Warning: missing terminating " character

  • Replace mpirun by standard mpiexec
  • Fix working directory of tests for MPI binaries

@fghoussen
Copy link
Collaborator

Thanks! Can you update the CHANGES log? And also add maybe a note there related to #391 (forgot to ask to update change log before merging #391)

@fghoussen
Copy link
Collaborator

fghoussen commented Jan 22, 2023

@FabienPean: just tried to push on top of you to see if we could also get MPI build/test... Bad idea! :( Reverting

fghoussen and others added 4 commits January 22, 2023 12:31
* Add flag `-fallow-invalid-boz` fixing false positive errors on comments
* Replace `mpirun` by standard `mpiexec`
* Fix working directory of tests for MPI binaries
@FabienPean
Copy link
Contributor Author

FabienPean commented Jan 24, 2023

The CI now also runs the MPI examples and the changelog has been updated. Changelog for #391 will come in a follow-up PR to make a small adjustment on the macro and its use

@FabienPean FabienPean changed the title Run examples for job windows_latest_cmake in CI Run all examples for job windows_latest_cmake in CI Jan 24, 2023
CMakeLists.txt Outdated Show resolved Hide resolved
@fghoussen fghoussen merged commit 12814dc into opencollab:master Jan 26, 2023
@fghoussen
Copy link
Collaborator

@FabienPean: merci Fabien ! :)

@FabienPean
Copy link
Contributor Author

Avec plaisir :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants